-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest grpc version (v1.39.0) for cmake build of otlp exporter. #927
Conversation
Codecov Report
@@ Coverage Diff @@
## main #927 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 160 160
Lines 6779 6779
=======================================
Hits 6464 6464
Misses 315 315 |
"${SRC_DIR}" | ||
grpc_cpp_plugin=`which grpc_cpp_plugin` | ||
proto_make_file="CMakeFiles/opentelemetry_proto.dir/build.make" | ||
sed -i "s~gRPC_CPP_PLUGIN_EXECUTABLE-NOTFOUND~$grpc_cpp_plugin~" ${proto_make_file} #fixme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually copied from here (existing otlp build action on ubuntu-latest):
Line 103 in ef16d00
sed -i "s~gRPC_CPP_PLUGIN_EXECUTABLE-NOTFOUND~$grpc_cpp_plugin~" ${proto_make_file} #fixme |
Somehow, cmake is not able to find the grpc_cpp_plugin
executable during configuration and so it has to be replaced manually in generated make
file before doing the actual make
.
I will debug this separately and fix in another PR.
Changes
we still need similar support for bazel. As of now, bazel builds uses grpc v1.33.2.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes