Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest grpc version (v1.39.0) for cmake build of otlp exporter. #927
Use latest grpc version (v1.39.0) for cmake build of otlp exporter. #927
Changes from all commits
b221f18
48bef11
72fa16d
4d48715
1ac7be7
007af85
5b87519
5c1bda5
a14806f
0d28b9c
4744d5f
7da8fcf
90ecacf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually copied from here (existing otlp build action on ubuntu-latest):
opentelemetry-cpp/ci/do_ci.sh
Line 103 in ef16d00
Somehow, cmake is not able to find the
grpc_cpp_plugin
executable during configuration and so it has to be replaced manually in generatedmake
file before doing the actualmake
.I will debug this separately and fix in another PR.