Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exporter.Stackdriver] Nullable #1130

Merged
merged 7 commits into from
Apr 24, 2023
Merged

[Exporter.Stackdriver] Nullable #1130

merged 7 commits into from
Apr 24, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Apr 5, 2023 •
edited by utpilla
Loading

Towards #894

Changes

[Exporter.Stackdriver] Nullable

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • Changes in public API reviewed

@github-actions github-actions bot requested a review from SergeyKanzhelev April 5, 2023 13:43
@Kielek Kielek marked this pull request as ready for review April 5, 2023 13:46
@Kielek Kielek requested a review from a team April 5, 2023 13:46
@Kielek
Copy link
Contributor Author

Kielek commented Apr 5, 2023

@SergeyKanzhelev please review

@utpilla utpilla added the comp:exporter.stackdriver Things related to OpenTelemetry.Exporter.Stackdriver label Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023 •
edited
Loading

Codecov Report

Merging #1130 (5349c27) into main (7c4ce8b) will increase coverage by 0.11%.
The diff coverage is 53.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
+ Coverage   72.41%   72.53%   +0.11%     
==========================================
  Files         227      236       +9     
  Lines        8408     8570     +162     
==========================================
+ Hits         6089     6216     +127     
- Misses       2319     2354      +35
Impacted Files Coverage Δ
...kdriver/Implementation/GoogleCloudResourceUtils.cs 68.75% <ø> (ø)
src/Shared/ActivityInstrumentationHelper.cs 100.00% <ø> (ø)
src/Shared/DiagnosticSourceListener.cs 70.00% <ø> (ø)
src/Shared/DiagnosticSourceSubscriber.cs 94.73% <ø> (ø)
src/Shared/ExceptionExtensions.cs 100.00% <ø> (ø)
src/Shared/Guard.cs 0.00% <ø> (ø)
src/Shared/InstrumentationEventSource.cs 12.50% <ø> (ø)
src/Shared/ListenerHandler.cs 55.55% <ø> (ø)
src/Shared/MultiTypePropertyFetcher.cs 80.00% <ø> (ø)
src/Shared/NullableAttributes.cs 0.00% <ø> (ø)
... and 7 more

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 19, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 19, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@Kielek Kielek removed the Stale label Apr 19, 2023
SergeyKanzhelev
SergeyKanzhelev approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Kielek Kielek merged commit 4becfe5 into open-telemetry:main Apr 24, 2023
@Kielek Kielek deleted the nullable-stackdriver branch April 24, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utpilla utpilla utpilla approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
comp:exporter.stackdriver Things related to OpenTelemetry.Exporter.Stackdriver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kielek @SergeyKanzhelev @utpilla