Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all projects with Nullable #894

Open
Kielek opened this issue Jan 12, 2023 · 5 comments
Open

Update all projects with Nullable #894

Kielek opened this issue Jan 12, 2023 · 5 comments
Assignees
@CodeBlanch

Comments

@Kielek
Copy link
Contributor

Kielek commented Jan 12, 2023 •
edited
Loading

Issue that does not fit into other categories

This issue is to track the effort of updating all projects to support Nullable and remove:

  <Nullable>disable</Nullable>

If possible enable projects one by one with corresponding Tests project to avoid huge PRs.

Ref: open-telemetry/opentelemetry-dotnet#3958
This was referenced Jan 12, 2023
Merged
Merged
@Kielek Kielek added .NET good first issue Good for newcomers help wanted Extra attention is needed labels Jan 12, 2023
@Kielek Kielek mentioned this issue Jan 19, 2023
Closed
2 tasks
@FernandoNunes
Copy link
Contributor

FernandoNunes commented Jan 24, 2023 •
edited
Loading

Hi @Kielek ,

I've started to pick this up. First PR is here: #920

If the required changes are all like the ones of this first PR, once is completed I'll do the rest of the projects / PRs.

@Kielek
Copy link
Contributor Author

Kielek commented Jan 24, 2023

@FernandoNunes, it is the goal, but I would expect more changes related to the code adjustment. See as an example: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/892/files.

Note: the tricky part could be OpenTelemetry.Contrib.Shared project which is compiled-in for multiple projects. What is more it is copied from main/SDK repository. It will be great to enable nullability there and then copy it here.

@Kielek Kielek mentioned this issue Jan 25, 2023
Merged
This was referenced Mar 16, 2023
Merged
Merged
This was referenced Mar 23, 2023
Merged
Merged
@utpilla utpilla mentioned this issue Apr 5, 2023
Merged
1 task
rypdal added a commit to rypdal/opentelemetry-dotnet-contrib that referenced this issue Aug 7, 2023
@rypdal
open-telemetry#894: enabled nullable for AWSLambda instrumentation
aa525f5
@Kielek Kielek mentioned this issue Aug 8, 2023
Merged
rypdal added a commit to rypdal/opentelemetry-dotnet-contrib that referenced this issue Aug 8, 2023
@rypdal
open-telemetry#894: allow nulls for ILambdaContext
ecc6330
rypdal added a commit to rypdal/opentelemetry-dotnet-contrib that referenced this issue Aug 8, 2023
@rypdal
open-telemetry#894: review suggestions
221f6ac
rypdal added a commit to rypdal/opentelemetry-dotnet-contrib that referenced this issue Aug 8, 2023
@rypdal @Oberon00
Update test/OpenTelemetry.Instrumentation.AWSLambda.Tests/Implementat…
fce5a66 
…ion/AWSMessagingUtilsTests.cs


open-telemetry#894: review suggestion

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
rypdal added a commit to rypdal/opentelemetry-dotnet-contrib that referenced this issue Aug 8, 2023
@rypdal
open-telemetry#894: made ILambdaContext non-nullable (for AWS lambda …
edd3e9d 
…functions it must be always available)
rypdal added a commit to rypdal/opentelemetry-dotnet-contrib that referenced this issue Aug 8, 2023
@rypdal
open-telemetry#894: added null-forgiving for passed tags and got rid …
0a62c40 
…of type casting
rypdal added a commit to rypdal/opentelemetry-dotnet-contrib that referenced this issue Aug 8, 2023
@rypdal @Oberon00
Update test/OpenTelemetry.Instrumentation.AWSLambda.Tests/Implementat…
490f16b 
…ion/AWSMessagingUtilsTests.cs


open-telemetry#894: applied suggestion

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
rypdal added a commit to rypdal/opentelemetry-dotnet-contrib that referenced this issue Aug 8, 2023
@rypdal
open-telemetry#894: further null-check improvements
556bd8a
rypdal added a commit to rypdal/opentelemetry-dotnet-contrib that referenced this issue Aug 9, 2023
@rypdal
open-telemetry#894: moved repeating null check to internal methods
888dbec
rypdal added a commit to rypdal/opentelemetry-dotnet-contrib that referenced this issue Aug 9, 2023
@rypdal
open-telemetry#894: review suggestions and other improvements
0bfa3ce
rypdal added a commit to rypdal/opentelemetry-dotnet-contrib that referenced this issue Aug 9, 2023
@rypdal
open-telemetry#894: additional review suggestions
6bfce39
rypdal added a commit to rypdal/opentelemetry-dotnet-contrib that referenced this issue Aug 9, 2023
@rypdal
open-telemetry#894: long lines split
7ba3940
rypdal added a commit to rypdal/opentelemetry-dotnet-contrib that referenced this issue Aug 9, 2023
@rypdal
open-telemetry#894: more line split
e257928
rypdal added a commit to rypdal/opentelemetry-dotnet-contrib that referenced this issue Aug 9, 2023
@rypdal
open-telemetry#894: removed unnecessary mentioning of test project
b0890f2
rypdal added a commit to rypdal/opentelemetry-dotnet-contrib that referenced this issue Aug 9, 2023
@rypdal
open-telemetry#894: fixed line length
0f828ec
This was referenced Sep 14, 2023
Merged
Merged
Merged
Merged
@repl-chris repl-chris mentioned this issue Sep 15, 2023
Merged
This was referenced Sep 18, 2023
Merged
Merged
Merged
Merged
@Kielek Kielek mentioned this issue Mar 5, 2024
Merged
This was referenced Apr 24, 2024
Merged
Open
@Kielek Kielek mentioned this issue May 13, 2024
Merged
@Kielek Kielek mentioned this issue May 20, 2024
Merged
1 task
@Kielek Kielek mentioned this issue Jun 12, 2024
Merged
@Kielek
Copy link
Contributor Author

Kielek commented Jun 12, 2024

@zivaninstana, would you like to contribute to this issue? Exporter.Instana still does not implement this feature.

@zivaninstana
Copy link
Contributor

Yes sure, I will take a look

@zivaninstana zivaninstana mentioned this issue Jun 25, 2024
Merged
@IliaBrahinets IliaBrahinets mentioned this issue Jul 1, 2024
Merged
4 tasks
@Kielek Kielek mentioned this issue Jul 8, 2024
Merged
3 tasks
@Kielek Kielek mentioned this issue Jul 26, 2024
Merged
2 tasks
@CodeBlanch CodeBlanch removed the .NET label Sep 17, 2024
@Kielek Kielek removed good first issue Good for newcomers help wanted Extra attention is needed labels Oct 4, 2024
@Kielek
Copy link
Contributor Author

Kielek commented Oct 4, 2024

Assigning @CodeBlanch as he is working on last part - Geneva exporter.

@IliaBrahinets IliaBrahinets mentioned this issue Oct 8, 2024
Merged
4 tasks
This was referenced Oct 28, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CodeBlanch CodeBlanch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@FernandoNunes @Kielek @CodeBlanch @zivaninstana