Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrumentation.Quartz] Nullable #1316

Merged
merged 3 commits into from
Aug 28, 2023
Merged

[Instrumentation.Quartz] Nullable #1316

merged 3 commits into from
Aug 28, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Aug 21, 2023

Towards #894

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • Changes in public API reviewed

@Kielek Kielek added the comp:instrumentation.quartz Things related to OpenTelemetry.Instrumentation.Quartz label Aug 21, 2023
@Kielek Kielek marked this pull request as ready for review August 21, 2023 08:17
@Kielek Kielek requested a review from a team August 21, 2023 08:17
@Kielek
Copy link
Contributor Author

Kielek commented Aug 21, 2023

@maldago, could you please review?

maldago
maldago approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@maldago maldago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issue with this. Thanks @Kielek

@Kielek
Copy link
Contributor Author

Kielek commented Aug 28, 2023

@maldago, could you please also check #1201?

(sorry for mixing topics, but I do not found any better way to send you a message.

@maldago maldago mentioned this pull request Aug 28, 2023
Closed
6 tasks
@Kielek Kielek merged commit 0007108 into open-telemetry:main Aug 28, 2023
@Kielek Kielek deleted the nullable-quartz branch August 28, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utpilla utpilla utpilla left review comments

@maldago maldago maldago approved these changes

Assignees
No one assigned
Labels
comp:instrumentation.quartz Things related to OpenTelemetry.Instrumentation.Quartz
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kielek @maldago @utpilla