Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable Hangfire #1352

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Nullable Hangfire #1352

merged 3 commits into from
Sep 18, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Sep 15, 2023

Towards #894

Changes

Nullable Hangfire.
Tests project already covered.

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • Changes in public API reviewed

@Kielek Kielek requested a review from a team September 15, 2023 05:44
@github-actions github-actions bot requested a review from fred2u September 15, 2023 05:44
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #1352 (07a4876) into main (b3c7ae7) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 07a4876 differs from pull request most recent head 462c6fd. Consider uploading reports for the commit 462c6fd to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1352   +/-   ##
=======================================
  Coverage   73.85%   73.86%           
=======================================
  Files         266      266           
  Lines        9598     9597    -1     
=======================================
  Hits         7089     7089           
+ Misses       2509     2508    -1     
Files Changed Coverage
...ntation.Hangfire/HangfireInstrumentationOptions.cs ø
...ation/HangfireInstrumentationJobFilterAttribute.cs ø
...tation.Hangfire/TracerProviderBuilderExtensions.cs ø

@utpilla utpilla added the comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire label Sep 15, 2023
@utpilla utpilla merged commit e5c597e into open-telemetry:main Sep 18, 2023
12 of 13 checks passed
@Kielek Kielek deleted the nullable-hangfire branch September 18, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants