Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASP.NET and OWIN Instrumentations - fix description for http.server.request.duration metric #1538

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Jan 18, 2024

Fixes #.

Changes

Update metric name for AspNet Instrumentation

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@Kielek Kielek requested a review from a team January 18, 2024 12:00
Co-authored-by: Mateusz Łach <mateusza@splunk.com>
@Kielek Kielek added the comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet label Jan 18, 2024
@Kielek Kielek changed the title [docs] Update metric name for AspNet Instrumentation AspNet and OWIN Instrumentations - fix description for http.server.request.duration metric Jan 19, 2024
@Kielek Kielek added the comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin label Jan 19, 2024
@Kielek Kielek changed the title AspNet and OWIN Instrumentations - fix description for http.server.request.duration metric ASP.NET and OWIN Instrumentations - fix description for http.server.request.duration metric Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71655ce) 73.91% compared to head (9f891a0) 78.61%.
Report is 118 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1538      +/-   ##
==========================================
+ Coverage   73.91%   78.61%   +4.70%     
==========================================
  Files         267       24     -243     
  Lines        9615      477    -9138     
==========================================
- Hits         7107      375    -6732     
+ Misses       2508      102    -2406     
Flag Coverage Δ
unittests-Instrumentation.AspNet 75.66% <ø> (?)
unittests-Instrumentation.Owin 85.71% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 267 files with indirect coverage changes

@vishweshbankwar vishweshbankwar merged commit 8a89a69 into open-telemetry:main Jan 19, 2024
26 checks passed
@Kielek Kielek deleted the fix-asp.net-metrics-docs branch January 19, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants