-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP Instrumentation - fix description for http.client.request.duration #5234
HTTP Instrumentation - fix description for http.client.request.duration #5234
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5234 +/- ##
==========================================
- Coverage 83.38% 83.19% -0.20%
==========================================
Files 297 271 -26
Lines 12531 11970 -561
==========================================
- Hits 10449 9958 -491
+ Misses 2082 2012 -70
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Is description change considered breaking change ? We should still treat it as bug and fix it.
Changing metric description should not be a breaking change as description is not part of metric identity. This should considered as bug fix. |
Looks like the description changed when the metric was renamed between convention v1.21.0 and v1.22.0. |
Fixes N/A
Design discussion issue # See similar PR open-telemetry/opentelemetry-dotnet-contrib#1538
Changes
HTTP Instrumentation - fix description for http.client.request.duration
Merge requirement checklist
[ ] Unit tests added/updatedCHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)