Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Instrumentation - fix description for http.client.request.duration #5234

Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Jan 19, 2024

Fixes N/A
Design discussion issue # See similar PR open-telemetry/opentelemetry-dotnet-contrib#1538

Changes

HTTP Instrumentation - fix description for http.client.request.duration

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team January 19, 2024 05:49
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6250307) 83.38% compared to head (2be3b3a) 83.19%.
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5234      +/-   ##
==========================================
- Coverage   83.38%   83.19%   -0.20%     
==========================================
  Files         297      271      -26     
  Lines       12531    11970     -561     
==========================================
- Hits        10449     9958     -491     
+ Misses       2082     2012      -70     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 25.05% <83.33%> (?)
unittests-Instrumentation-Stable 25.07% <83.33%> (?)
unittests-Solution-Experimental 83.13% <100.00%> (?)
unittests-Solution-Stable 83.05% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tation.AspNetCore/Implementation/HttpInListener.cs 89.72% <100.00%> (+0.14%) ⬆️
...plementation/HttpWebRequestActivitySource.netfx.cs 80.77% <100.00%> (ø)
...emetry/Metrics/Exemplar/SimpleExemplarReservoir.cs 80.43% <100.00%> (ø)

... and 33 files with indirect coverage changes

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Is description change considered breaking change ? We should still treat it as bug and fix it.

@vishweshbankwar
Copy link
Member

Thanks. Is description change considered breaking change ? We should still treat it as bug and fix it.

Changing metric description should not be a breaking change as description is not part of metric identity. This should considered as bug fix.

@TimothyMothra
Copy link
Contributor

Looks like the description changed when the metric was renamed between convention v1.21.0 and v1.22.0.
Thanks for catching this!

@alanwest alanwest merged commit dfd27c5 into open-telemetry:main Jan 19, 2024
44 checks passed
@Kielek Kielek deleted the http-instrumentation-fix-description branch January 20, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants