Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.Owin] Nullable #1601

Merged
merged 8 commits into from
Mar 13, 2024
Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Mar 5, 2024

Towards #894

Changes

[Instrumentation.Owin] Nullable

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@github-actions github-actions bot requested a review from CodeBlanch March 5, 2024 07:29
@Kielek Kielek changed the title ]Instrumentation.Owin] Nullable [Instrumentation.Owin] Nullable Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (71655ce) to head (8740c4f).
Report is 162 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1601       +/-   ##
===========================================
+ Coverage   73.91%   85.71%   +11.79%     
===========================================
  Files         267        8      -259     
  Lines        9615      140     -9475     
===========================================
- Hits         7107      120     -6987     
+ Misses       2508       20     -2488     
Flag Coverage Δ
unittests-Instrumentation.Owin 85.71% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ation.Owin/Implementation/DiagnosticsMiddleware.cs 89.42% <100.00%> (-2.44%) ⬇️
...mplementation/OwinInstrumentationActivitySource.cs 100.00% <100.00%> (ø)
...Instrumentation.Owin/OwinInstrumentationOptions.cs 100.00% <100.00%> (ø)
...umentation.Owin/TracerProviderBuilderExtensions.cs 83.33% <ø> (ø)

... and 260 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review March 5, 2024 07:38
@Kielek Kielek requested a review from a team March 5, 2024 07:38
@Kielek Kielek added the comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin label Mar 5, 2024
@Kielek Kielek requested a review from utpilla March 12, 2024 05:37
@utpilla utpilla merged commit 01c2257 into open-telemetry:main Mar 13, 2024
26 checks passed
@Kielek Kielek deleted the owin-nullable branch March 14, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants