[Instrumentation.AspNet] Spans - semantic convention v1.24.0 #1607
Conversation
Kielek
added
the
comp:instrumentation.aspnet
Kielek
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1607 +/- ##
==========================================
- Coverage 73.91% 65.84% -8.08%
==========================================
Files 267 233 -34
Lines 9615 8728 -887
==========================================
- Hits 7107 5747 -1360
- Misses 2508 2981 +473
Flags with carried forward coverage won't be shown. Click here to find out more.
|
test/OpenTelemetry.Instrumentation.AspNet.Tests/RequestDataHelperTests.cs
Outdated
Show resolved
Hide resolved
| { | ||
| activity.SetTag(SemanticConventions.AttributeHttpHost, request.Url.Host + ":" + request.Url.Port); | ||
| if (query.StartsWith("?", StringComparison.InvariantCulture)) |
There was a problem hiding this comment.
@Kielek - Does spec requires it to be without ?
There was a problem hiding this comment.
I am not sure if it hard requierment, but all examples are without this sign.
There was a problem hiding this comment.
Looks like it doesn't include the ? component, https://www.rfc-editor.org/rfc/rfc3986#section-3.4
src/OpenTelemetry.Instrumentation.AspNet/Implementation/HttpInListener.cs
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.AspNet/Implementation/HttpInListener.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.AspNet/Implementation/RequestDataHelper.cs
Show resolved
Hide resolved
| @@ -8,6 +8,9 @@ | |||
| * **Breaking Change**: `server.address` and `server.port` no longer added | |||
| for `http.server.request.duration` metric. | |||
| ([#1606](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1606)) | |||
| * **Breaking change** Spans names and attributes | |||
There was a problem hiding this comment.
Could you please include the details on new versus old attributes?
Something like this: https://opentelemetry.io/blog/2023/http-conventions-declared-stable/#summary-of-changes
|
@vishweshbankwar, changes in changelog: fb25884, please review once more time. |
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Fixes N/A
Changes
Span attributes based on HTTP semantic convention v1.24.0 - Common and Server part sections.
Span names:
Common part
error.type- ccb1d4fhttp.request.methodandhttp.request.method_original- e31b687http.response.header.<key>- Opn-In - skipping for nowhttp.response.status_code- 5677f4fnetwork.peer.addressandnetwork.peer.port- Recommended - skipping for nownetwork.protocol.name- empty, means HTTP by defaultnetwork.protocol.version- a794951network.transport- Opn-In - skipping for nowServer part:
client.address- Recommended - skipping for nowclient.port- Opt-In skipping for nowhttp.request.header.<key>- Opt-In skipping for nowhttp.route- already handled, no changesnetwork.local.addressandnetwork.local.port- Opt-In skipping for nowserver.addressandserver.port- 3d3ce2eurl.path- 86fdf5aurl.query- e920468url.scheme- 445a684user_agent.original- 78e266aConsider to review commits separately.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes[ ] Design discussion issue #[ ] Changes in public API reviewed