-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.AspNet] Spans - semantic convention v1.24.0 #1607
Merged
Merged
Changes from 19 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
957c235
Use newer version from semantic convention
Kielek 3d3ce2e
Use server.address and server.port attributes
Kielek e31b687
Fix http.request.method and http.request.method_original
Kielek 5677f4f
Fix http.response.status_code
Kielek 78e266a
Fix user_agent.original
Kielek 86fdf5a
Fix url.path
Kielek 445a684
Fix url.scheme
Kielek a794951
Fix network.protocol.version
Kielek f0ce187
Drop http.url attribute
Kielek e920468
Fix url.query
Kielek ccb1d4f
Fix error.type
Kielek e5d62dc
Update CHANGELOG
Kielek c9b36e5
dotnet format
Kielek ac62f91
Merge branch 'main' into aspnet-traces
Kielek 7792287
Merge branch 'main' into aspnet-traces
Kielek 8e846ee
PR feedback
Kielek beb1d18
Merge branch 'main' into aspnet-traces
Kielek 3a108ff
PR feedback - extract method
Kielek 7feba09
PR feedback - fix paramether name
Kielek 87bf97b
Fix span names
Kielek a44060b
Merge branch 'main' into aspnet-traces
Kielek fdf91b8
PR feedback - check null/empty user agent
Kielek c8ced77
Merge branch 'main' into aspnet-traces
Kielek fb25884
PR feedback - extend CHANGELOG
Kielek 8d441c0
Update src/OpenTelemetry.Instrumentation.AspNet/CHANGELOG.md
Kielek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kielek - Does spec requires it to be without
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if it hard requierment, but all examples are without this sign.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it doesn't include the
?
component, https://www.rfc-editor.org/rfc/rfc3986#section-3.4