Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrumentation.GrpcCore] Nullable support #1936

Merged
merged 16 commits into from
Jul 5, 2024
Merged

[Instrumentation.GrpcCore] Nullable support #1936

merged 16 commits into from
Jul 5, 2024

Conversation

IliaBrahinets
Copy link
Member

@IliaBrahinets IliaBrahinets commented Jul 1, 2024 •
edited
Loading

Related to #894

Changes

  • Nullable support for both Instrumentation.GrpcCore and Instrumentation.GrpcCore.Tests
  • Minimal supported version update of Grpc.Core.Api to 2.43.0 as it is the minimal version with nullable support
  • Update of Grpc.Tools to 2.38.0 for Instrumentation.GrpcCore.Tests

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot requested a review from pcwiese July 1, 2024 20:14
@github-actions github-actions bot added the comp:instrumentation.grpccore Things related to OpenTelemetry.Instrumentation.GrpcCore label Jul 1, 2024
@IliaBrahinets
Update changelog
f705c5e
@IliaBrahinets
Merge branch 'main' into nullable-for-grpc-core
e086afe 
# Conflicts:
#	src/OpenTelemetry.Instrumentation.GrpcCore/RpcScope.cs
@IliaBrahinets
Nullable warnings fix
7802fbc
@IliaBrahinets IliaBrahinets marked this pull request as ready for review July 2, 2024 21:53
@IliaBrahinets IliaBrahinets requested a review from a team July 2, 2024 21:53
@IliaBrahinets
Copy link
Member Author

@Kielek , I've made changes according to the comments. Ready for another review.

@Kielek Kielek merged commit d6aff08 into open-telemetry:main Jul 5, 2024
59 checks passed
@IliaBrahinets IliaBrahinets deleted the nullable-for-grpc-core branch July 5, 2024 08:20
@IliaBrahinets IliaBrahinets mentioned this pull request Jul 5, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kielek Kielek Kielek approved these changes

@pcwiese pcwiese Awaiting requested review from pcwiese

Assignees

@IliaBrahinets IliaBrahinets

@pcwiese pcwiese

Labels
comp:instrumentation.grpccore Things related to OpenTelemetry.Instrumentation.GrpcCore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IliaBrahinets @Kielek @pcwiese