Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Nulls on Contrib.Instrumentation.AWS & Test Projects #926

Conversation

FernandoNunes
Copy link
Contributor

@FernandoNunes FernandoNunes commented Jan 24, 2023

Towards #894

Changes

Enabled Nulls on Contrib.Instrumentation.AWS & Test Projects

@FernandoNunes FernandoNunes requested a review from a team January 24, 2023 23:17
@github-actions github-actions bot requested a review from srprash January 24, 2023 23:17
@Kielek Kielek added the comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS label Jan 25, 2023
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have some compilation errors to resolve before review.

@FernandoNunes
Copy link
Contributor Author

Hi @Kielek can you aprove this PR workflows to see if it checks in correctly ?

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #926 (77233b0) into main (c7d64b5) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #926   +/-   ##
=======================================
  Coverage   69.69%   69.69%           
=======================================
  Files         202      202           
  Lines        7699     7699           
=======================================
  Hits         5366     5366           
  Misses       2333     2333           
Impacted Files Coverage Δ
...rumentation.AWS/TracerProviderBuilderExtensions.cs 100.00% <ø> (ø)
...on.AWS/Implementation/AWSTracingPipelineHandler.cs 91.39% <100.00%> (ø)
...ontrib.Instrumentation.AWS/Implementation/Utils.cs 75.00% <100.00%> (ø)

@FernandoNunes
Copy link
Contributor Author

The test that failed was on a project that wasn't even touched, and on my dev machine locally all tests pass.

[xUnit.net 00:00:01.91] OpenTelemetry.Instrumentation.EventCounters.Tests.EventCountersMetricsTests.EventCounter [FAIL]
[xUnit.net 00:00:01.91] Assert.Equal() Failure
[xUnit.net 00:00:01.91] Expected: 1997.0201999999999
[xUnit.net 00:00:01.91] Actual: 0
[xUnit.net 00:00:01.91] Stack Trace:
[xUnit.net 00:00:01.91] D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\test\OpenTelemetry.Instrumentation.EventCounters.Tests\EventCountersMetricsTests.cs(74,0): at OpenTelemetry.Instrumentation.EventCounters.Tests.EventCountersMetricsTests.EventCounter()
Failed OpenTelemetry.Instrumentation.EventCounters.Tests.EventCountersMetricsTests.EventCounter [1 s]
Error Message:
Assert.Equal() Failure
Expected: 1997.0201999999999
Actual: 0
Stack Trace:
at OpenTelemetry.Instrumentation.EventCounters.Tests.EventCountersMetricsTests.EventCounter() in D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\test\OpenTelemetry.Instrumentation.EventCounters.Tests\EventCountersMetricsTests.cs:line 74

@FernandoNunes FernandoNunes requested review from Kielek and removed request for srprash February 1, 2023 20:34
@github-actions github-actions bot requested a review from srprash February 2, 2023 08:45
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 10, 2023
@Kielek Kielek removed the Stale label Feb 10, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 23, 2023
@github-actions github-actions bot removed the Stale label Feb 25, 2023
@utpilla utpilla merged commit 25632df into open-telemetry:main Mar 2, 2023
@FernandoNunes FernandoNunes deleted the EnableNulls_Contrib_Instrumentation_AWS branch March 3, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants