-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Nulls on Contrib.Instrumentation.AWS & Test Projects #926
Enable Nulls on Contrib.Instrumentation.AWS & Test Projects #926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still have some compilation errors to resolve before review.
...try.Contrib.Instrumentation.AWS.Tests/OpenTelemetry.Contrib.Instrumentation.AWS.Tests.csproj
Outdated
Show resolved
Hide resolved
Removed unnecessary Test project settings
Hi @Kielek can you aprove this PR workflows to see if it checks in correctly ? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #926 +/- ##
=======================================
Coverage 69.69% 69.69%
=======================================
Files 202 202
Lines 7699 7699
=======================================
Hits 5366 5366
Misses 2333 2333
|
The test that failed was on a project that wasn't even touched, and on my dev machine locally all tests pass. [xUnit.net 00:00:01.91] OpenTelemetry.Instrumentation.EventCounters.Tests.EventCountersMetricsTests.EventCounter [FAIL] |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Towards #894
Changes
Enabled Nulls on Contrib.Instrumentation.AWS & Test Projects