-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge aspnet-telemetrycorrelation branch back to main #2233
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2233 +/- ##
==========================================
- Coverage 80.14% 79.11% -1.04%
==========================================
Files 227 237 +10
Lines 7173 7484 +311
==========================================
+ Hits 5749 5921 +172
- Misses 1424 1563 +139
|
marking as "donotmerge" until we temporarily enable merge-with-keep-commits. |
And we want to wait to get approval (or rejection) from @CodeBlanch as he will be taking it further after I finished the grunt work. |
…entation.AspNet.TelemetryHttpModule. Added project to the solution + updated references & namespaces. (#2238)
I think we're good to merge this now. @cijothomas What do we do with API Compatability check on new projects? |
Similar to the below: |
I've disabled the API Compat check for this module, also fixed a trailing space issue in the README doc. |
Part of #2222.
Note: we need to merge this PR by keeping all the commits rather than squashing them (so we know what's been copied over directly vs. changed by the OpenTelemetry .NET community).
Note: I didn't include the changelog yet, we might want to add a single entry with all the related PRs, similar like what we've done in the spec repo https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md#metrics-2.
@CodeBlanch I think we have two options, want to get your opinion:
aspnet-telemetrycorrelation
branch, which means you will continue the refactor (including renaming the package/namespace and the integration with ASP.NET instrumentation), and once you finished, merge this PR (which will be bigger at that time) to main.