-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate environment variable parsing #2500
Merged
cijothomas
merged 26 commits into
open-telemetry:main
from
pellared:refine-env-vars-parsing
Oct 26, 2021
Merged
Consolidate environment variable parsing #2500
cijothomas
merged 26 commits into
open-telemetry:main
from
pellared:refine-env-vars-parsing
Oct 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2500 +/- ##
==========================================
+ Coverage 80.47% 80.59% +0.11%
==========================================
Files 253 254 +1
Lines 8549 8507 -42
==========================================
- Hits 6880 6856 -24
+ Misses 1669 1651 -18
|
pellared
commented
Oct 20, 2021
pellared
commented
Oct 20, 2021
test/OpenTelemetry.Tests/Internal/EnvironmentVariableHelperTests.cs
Outdated
Show resolved
Hide resolved
lachmatt
reviewed
Oct 20, 2021
pellared
changed the title
[WIP] Introduce EnvironmentVariableHelper
[WIP] Consolidate environmental variable parsing
Oct 20, 2021
pellared
changed the title
[WIP] Consolidate environmental variable parsing
Consolidate environment variable parsing
Oct 20, 2021
mic-max
reviewed
Oct 21, 2021
mic-max
approved these changes
Oct 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for making this change :)
Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com>
reyang
approved these changes
Oct 26, 2021
alanwest
reviewed
Oct 26, 2021
alanwest
reviewed
Oct 26, 2021
alanwest
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Address: #2219 (comment) proposed by @reyang
Partially addresses #1453.
What
Introduce
EnvironmentVariableHelper
and reuse it when reading the environmental variables.Remarks
I also created open-telemetry/opentelemetry-specification#2045 when working on this issue. Thumbs up, approvals, comments, any feedback put there is welcome 😉