Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary try catch for SecurityException #2531

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

pellared
Copy link
Member

Addresses @alanwest comment: #2500 (comment).

Changes

Remove unnecessary try-catch for SecurityException since LoadString already does it.

@pellared pellared requested a review from a team October 27, 2021 05:49
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #2531 (806a90f) into main (6350288) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2531      +/-   ##
==========================================
+ Coverage   80.51%   80.54%   +0.02%     
==========================================
  Files         254      254              
  Lines        8515     8505      -10     
==========================================
- Hits         6856     6850       -6     
+ Misses       1659     1655       -4     
Impacted Files Coverage Δ
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 69.52% <ø> (-1.51%) ⬇️
...OpenTelemetry/Resources/OtelEnvResourceDetector.cs 100.00% <100.00%> (+18.75%) ⬆️
...lemetry/Resources/OtelServiceNameEnvVarDetector.cs 100.00% <100.00%> (+27.27%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (-2.95%) ⬇️

@cijothomas cijothomas merged commit d026232 into open-telemetry:main Oct 27, 2021
@pellared pellared deleted the remove-unneeded-try-catch branch October 27, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants