-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk-traces] SamplingResult constructors accept null parameters #5614
Merged
CodeBlanch
merged 5 commits into
open-telemetry:main
from
Kielek:fix-nullability-SamplingResult
May 16, 2024
Merged
[sdk-traces] SamplingResult constructors accept null parameters #5614
CodeBlanch
merged 5 commits into
open-telemetry:main
from
Kielek:fix-nullability-SamplingResult
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
force-pushed
the
fix-nullability-SamplingResult
branch
from
May 14, 2024 09:23
512be15
to
547cd87
Compare
Kielek
force-pushed
the
fix-nullability-SamplingResult
branch
from
May 14, 2024 09:38
547cd87
to
ee26cbb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5614 +/- ##
==========================================
+ Coverage 83.38% 85.66% +2.28%
==========================================
Files 297 254 -43
Lines 12531 10982 -1549
==========================================
- Hits 10449 9408 -1041
+ Misses 2082 1574 -508
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kielek
changed the title
SamplingResult constructor accepts null parameters
SamplingResult constructors accept null parameters
May 14, 2024
reyang
reviewed
May 14, 2024
CodeBlanch
reviewed
May 14, 2024
reyang
added
pkg:OpenTelemetry
Issues related to OpenTelemetry NuGet package
and removed
pkg:OpenTelemetry
labels
May 14, 2024
Kielek
commented
May 15, 2024
reyang
approved these changes
May 15, 2024
vishweshbankwar
approved these changes
May 15, 2024
rajkumar-rangaraj
approved these changes
May 15, 2024
CodeBlanch
changed the title
SamplingResult constructors accept null parameters
[sdk-traces] SamplingResult constructors accept null parameters
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/opentelemetry-dotnet-contrib#1718 (comment)
Design discussion issue #
Changes
SamplingResult constructor accepts null parameters
Merge requirement checklist
[ ] Unit tests added/updatedCHANGELOG.md
files updated for non-trivial changes