-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.AspNetCore] Nullable enabled #1718
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
==========================================
+ Coverage 73.91% 76.08% +2.16%
==========================================
Files 267 297 +30
Lines 9615 11620 +2005
==========================================
+ Hits 7107 8841 +1734
- Misses 2508 2779 +271 Flags with carried forward coverage won't be shown. Click here to find out more.
|
{ | ||
var activity = Activity.Current; | ||
|
||
if (activity == null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use Activity.Current!
? IIRC, this is already checked at caller side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed: 1aaea52
it is always not-null (checked in parent method)
Towards #894
Changes
[Instrumentation.AspNetCore] Nullable enabled
Move shared files to Shared folder
For significant contributions please make sure you have completed the following items:
[ ] AppropriateCHANGELOG.md
updated for non-trivial changes[ ] Design discussion issue #[ ] Changes in public API reviewed