Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AspNetCore] Nullable enabled #1718

Merged
merged 7 commits into from
May 15, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented May 13, 2024

Towards #894

Changes

[Instrumentation.AspNetCore] Nullable enabled
Move shared files to Shared folder

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@Kielek Kielek added the comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.08%. Comparing base (71655ce) to head (7e5b561).
Report is 238 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1718      +/-   ##
==========================================
+ Coverage   73.91%   76.08%   +2.16%     
==========================================
  Files         267      297      +30     
  Lines        9615    11620    +2005     
==========================================
+ Hits         7107     8841    +1734     
- Misses       2508     2779     +271     
Flag Coverage Δ
unittests-Exporter.Geneva 63.77% <ø> (?)
unittests-Exporter.OneCollector 89.72% <ø> (?)
unittests-Extensions 79.33% <ø> (?)
unittests-Instrumentation.AspNet 74.39% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <100.00%> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 78.78% <ø> (?)
unittests-Instrumentation.Http 81.79% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-ResourceDetectors.Azure 81.53% <ø> (?)
unittests-ResourceDetectors.Host 54.11% <ø> (?)
unittests-ResourceDetectors.Process 100.00% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 76.08% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Solution 80.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...umentation.AspNetCore/AspNetCoreInstrumentation.cs 100.00% <100.00%> (ø)
...eInstrumentationTracerProviderBuilderExtensions.cs 100.00% <ø> (ø)
...ry.Instrumentation.AspNetCore/AspNetCoreMetrics.cs 100.00% <100.00%> (ø)
...spNetCore/AspNetCoreTraceInstrumentationOptions.cs 95.23% <100.00%> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs 77.02% <100.00%> (ø)
...AspNetCore/Implementation/HttpInMetricsListener.cs 89.74% <100.00%> (ø)

... and 276 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review May 13, 2024 06:46
@Kielek Kielek requested a review from a team May 13, 2024 06:46
{
var activity = Activity.Current;

if (activity == null)
Copy link
Member

@vishweshbankwar vishweshbankwar May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use Activity.Current!? IIRC, this is already checked at caller side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: 1aaea52

@Kielek Kielek merged commit c5e8f19 into open-telemetry:main May 15, 2024
153 of 154 checks passed
@Kielek Kielek deleted the aspnetcore-nullable branch May 15, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants