-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom ring implementation to the BatchProcessor #5237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:SDK
Related to an SDK package
area:logs
Part of OpenTelemetry logs
Skip Changelog
PRs that do not require a CHANGELOG.md entry
labels
Apr 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5237 +/- ##
=====================================
Coverage 84.5% 84.6%
=====================================
Files 258 259 +1
Lines 17349 17384 +35
=====================================
+ Hits 14676 14708 +32
- Misses 2362 2365 +3
Partials 311 311
|
MrAlias
force-pushed
the
blp-ring
branch
3 times, most recently
from
April 19, 2024 17:03
59c88db
to
36edfb3
Compare
8 tasks
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
April 19, 2024 17:22
pellared
reviewed
Apr 22, 2024
pellared
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment that it would be nice to address.
dmathieu
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:logs
Part of OpenTelemetry logs
pkg:SDK
Related to an SDK package
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5063
The current queue implementation uses the built-in
container/ring
package for a ring implementation. This implementation stores its value as anany
. Each time the batch processor stores aRecord
to this field it needs to be allocated to the heap to convert it to anany
type.This changes the implementation to be a paired-down ring with a
Record
as the value field. This removes the allocation and greatly improves the performance of the batch processor.Benchmarks