-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Schema URL when exporting traces to OTLP #2242
Set Schema URL when exporting traces to OTLP #2242
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2242 +/- ##
=====================================
Coverage 72.4% 72.5%
=====================================
Files 168 168
Lines 11766 11768 +2
=====================================
+ Hits 8530 8532 +2
Misses 3001 3001
Partials 235 235
|
@Aneurysm9 @MrAlias This does not change anything in the API, but it changes OTLP exporter behavior. Do we need a CHANGELOG entry for this? |
I think a changelog entry for this would be good as it can allow people to discover when a capability was added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks; also note #2197 plumbs the instrumentation library schema through to the OTLP exporter for metrics, so that its schema URL can be set in the corresponding message.
We previously were recording the Schema URL but were not setting the recorded value when exporting. This change now uses the recorded value when exporting to OTLP.
25c9e39
to
884c2d7
Compare
Changelog entry added. |
I think this is ready to be merged. |
We previously were recording the Schema URL but were not setting
the recorded value when exporting. This change now uses the recorded
value when exporting to OTLP.