-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics: Move the non-API types into sdkapi
#2271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
dashpole,
evantorrie,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
September 30, 2021 22:51
Codecov Report
@@ Coverage Diff @@
## main #2271 +/- ##
=====================================
Coverage 72.5% 72.6%
=====================================
Files 168 170 +2
Lines 11874 11873 -1
=====================================
+ Hits 8611 8621 +10
+ Misses 3029 3019 -10
+ Partials 234 233 -1
|
Aneurysm9
approved these changes
Sep 30, 2021
MrAlias
reviewed
Oct 11, 2021
MrAlias
approved these changes
Oct 14, 2021
😀 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is entirely changes of name with a few new tests, no functional changes.
The following interface types simply move:
Descriptor
MeterImpl
InstrumentImpl
SyncImpl
BoundSyncImpl
AsyncImpl
AsyncRunner
AsyncSingleRunner
AsyncBatchRunner
The following structs are moved:
Measurement
Observation
As the type structs are exposed to users, they have been given type aliases in the API.
The No-op implementations of sync and async instruments are no longer exported. New functions
sdkapi.NewNoopAsyncInstrument()
andsdkapi.NewNoopSyncInstrument()
are provided instead.This is a follow-on to #2197, which did all of the hard work in preparation for this change.
Fixes #2090.