Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CI default version of Go to 1.20 #3733

Merged
merged 9 commits into from
Feb 16, 2023
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 15, 2023

Developers likely use the latest release of Go in development and we want to catch any bugs (e.g. lint errors, race detection) with the this release before they are merged. Therefore, update the default version the CI system uses to be the latest.

In the process of updating, this also removes use of deprecated math/rand functionality. This functionality was deprecated in Go 1.20.

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #3733 (cac8403) into main (d68b05f) will increase coverage by 1.6%.
The diff coverage is 0.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3733     +/-   ##
=======================================
+ Coverage   79.7%   81.3%   +1.6%     
=======================================
  Files        171     166      -5     
  Lines      12709   12451    -258     
=======================================
  Hits       10130   10130             
+ Misses      2363    2105    -258     
  Partials     216     216             
Impacted Files Coverage Δ
...orters/otlp/otlpmetric/internal/otest/collector.go 6.9% <0.0%> (+<0.1%) ⬆️
...ters/otlp/otlptrace/internal/otlptracetest/data.go
.../otlp/otlptrace/internal/otlptracetest/otlptest.go
metric/global/global.go
...otlp/otlptrace/internal/otlptracetest/collector.go
...rs/otlp/otlptrace/internal/otlptracetest/client.go

.github/workflows/ci.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Damien Mathieu <42@dmathieu.com>
@MrAlias
Copy link
Contributor Author

MrAlias commented Feb 16, 2023

This is blocking development efforts, going to merge this slightly earlier than 1 full day.

@XSAM XSAM added this to the Old Untracked PRs milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants