-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CI default version of Go to 1.20 #3733
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3733 +/- ##
=======================================
+ Coverage 79.7% 81.3% +1.6%
=======================================
Files 171 166 -5
Lines 12709 12451 -258
=======================================
Hits 10130 10130
+ Misses 2363 2105 -258
Partials 216 216 |
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
February 15, 2023 19:41
MrAlias
commented
Feb 15, 2023
dmathieu
reviewed
Feb 15, 2023
Co-authored-by: Damien Mathieu <42@dmathieu.com>
dmathieu
approved these changes
Feb 16, 2023
dashpole
approved these changes
Feb 16, 2023
This is blocking development efforts, going to merge this slightly earlier than 1 full day. |
This was referenced Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers likely use the latest release of Go in development and we want to catch any bugs (e.g. lint errors, race detection) with the this release before they are merged. Therefore, update the default version the CI system uses to be the latest.
In the process of updating, this also removes use of deprecated
math/rand
functionality. This functionality was deprecated in Go 1.20.