Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] Refactor aggregation and add exemplars support #4220

Closed
wants to merge 1 commit into from

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jun 14, 2023

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics proposal labels Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #4220 (e268cc5) into main (844b107) will decrease coverage by 0.6%.
The diff coverage is 66.3%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4220     +/-   ##
=======================================
- Coverage   83.3%   82.7%   -0.6%     
=======================================
  Files        181     192     +11     
  Lines      13986   14714    +728     
=======================================
+ Hits       11657   12179    +522     
- Misses      2102    2301    +199     
- Partials     227     234      +7     
Impacted Files Coverage Δ
sdk/metric/internal/aggregate/hist.go 0.0% <0.0%> (ø)
sdk/metric/internal/exemplar/drop.go 0.0% <0.0%> (ø)
sdk/metric/internal/exemplar/hist.go 0.0% <0.0%> (ø)
sdk/metric/internal/exemplar/filter.go 50.0% <50.0%> (ø)
sdk/metric/internal/exemplar/rand.go 69.2% <69.2%> (ø)
sdk/metric/internal/exemplar/measurement.go 74.2% <74.2%> (ø)
sdk/metric/internal/aggregate/aggregate.go 78.0% <78.0%> (ø)
sdk/metric/internal/aggregate/lastval.go 100.0% <100.0%> (ø)
sdk/metric/internal/aggregate/sum.go 100.0% <100.0%> (ø)
sdk/metric/internal/exemplar/fixed.go 100.0% <100.0%> (ø)
... and 1 more

... and 5 files with indirect coverage changes

MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Jul 19, 2023
Part of open-telemetry#4220

Instead of using an aggregator to filter measured attributes, directly
filter the attributes in the constructed Measure function the Builder
creates.

Include unit and integration testing of new filtering.
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Jul 19, 2023
Part of open-telemetry#4220

Instead of using an aggregator to filter measured attributes, directly
filter the attributes in the constructed Measure function the Builder
creates.

Include unit and integration testing of new filtering.
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Jul 19, 2023
Part of open-telemetry#4220

Instead of using an aggregator to filter measured attributes, directly
filter the attributes in the constructed Measure function the Builder
creates.

Include unit and integration testing of new filtering.
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Jul 19, 2023
Part of open-telemetry#4220

Instead of using an aggregator to filter measured attributes, directly
filter the attributes in the constructed Measure function the Builder
creates.

Include unit and integration testing of new filtering.
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Jul 19, 2023
Part of open-telemetry#4220

Instead of using an aggregator to filter measured attributes, directly
filter the attributes in the constructed Measure function the Builder
creates.

Include unit and integration testing of new filtering.
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Jul 19, 2023
Part of open-telemetry#4220

Instead of using an aggregator to filter measured attributes, directly
filter the attributes in the constructed Measure function the Builder
creates.

Include unit and integration testing of new filtering.
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Jul 19, 2023
Part of open-telemetry#4220

Instead of using an aggregator to filter measured attributes, directly
filter the attributes in the constructed Measure function the Builder
creates.

Include unit and integration testing of new filtering.
MrAlias added a commit that referenced this pull request Jul 20, 2023
* Replace filter aggregator with direct filter on measure

Part of #4220

Instead of using an aggregator to filter measured attributes, directly
filter the attributes in the constructed Measure function the Builder
creates.

Include unit and integration testing of new filtering.

* Update sdk/metric/internal/aggregate/aggregate.go

Co-authored-by: David Ashpole <dashpole@google.com>

---------

Co-authored-by: David Ashpole <dashpole@google.com>
@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 21, 2023

Replace with #4455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant