Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move aggregators to internal/aggregate #4283

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Move aggregators to internal/aggregate #4283

merged 3 commits into from
Jul 3, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jun 30, 2023

Part of #4220

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics Skip Changelog PRs that do not require a CHANGELOG.md entry labels Jun 30, 2023
@codecov
Copy link

codecov bot commented Jul 1, 2023 •
edited
Loading

Codecov Report

Merging #4283 (d97bdb0) into main (97273da) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4283   +/-   ##
=====================================
  Coverage   83.5%   83.5%           
=====================================
  Files        183     183           
  Lines      14207   14207           
=====================================
+ Hits       11865   11869    +4     
+ Misses      2114    2110    -4     
  Partials     228     228
Impacted Files Coverage Δ
sdk/metric/internal/aggregate/filter.go 100.0% <ø> (ø)
sdk/metric/internal/aggregate/histogram.go 100.0% <ø> (ø)
sdk/metric/internal/aggregate/lastvalue.go 100.0% <ø> (ø)
sdk/metric/internal/aggregate/sum.go 100.0% <ø> (ø)
sdk/metric/instrument.go 93.0% <100.0%> (ø)
sdk/metric/meter.go 85.9% <100.0%> (ø)
sdk/metric/pipeline.go 91.4% <100.0%> (ø)

... and 2 files with indirect coverage changes

@pellared pellared merged commit 10c3445 into open-telemetry:main Jul 3, 2023
@MrAlias MrAlias deleted the new-aggregate-pkg branch July 3, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@dashpole dashpole dashpole approved these changes

@dmathieu dmathieu dmathieu approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung

Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v1.17.0/v0.40.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MrAlias @dmathieu @dashpole @pellared