Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support environment variables in manager #142

Merged
merged 6 commits into from
Mar 9, 2022
Merged

feat: support environment variables in manager #142

merged 6 commits into from
Mar 9, 2022

Conversation

mat-rumian
Copy link
Contributor

@mat-rumian mat-rumian commented Mar 7, 2022 •
edited
Loading

This PR adds support for configuration of additional environment variables needed to configure Opentelemetry-Operator Manager. Thanks to that WATCH_NAMESPACE variable can be configured during chart deployment.

Functionality:

  • If values.manager.env is empty then env is not added to the manager deployment (default)
  • If values.manager.env contains map (KEY: value) then it's added to the manager deployment as k8s env obj

@mat-rumian mat-rumian requested review from a team March 7, 2022 12:01
@mat-rumian mat-rumian changed the title Support environment variables in manager feat: support environment variables in manager Mar 7, 2022
@TylerHelmuth
Copy link
Member

Please bump the operator chart version.

@dmitryax
Copy link
Member

dmitryax commented Mar 7, 2022

@dmitryax another use case for expanding the values.schema.json for operator charts?

Yes, indeed

TylerHelmuth
TylerHelmuth approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax merged commit 249a2a0 into open-telemetry:main Mar 9, 2022
@mat-rumian mat-rumian deleted the support-env-vars-in-manager branch March 9, 2022 09:23
dmitryax added a commit that referenced this pull request Mar 18, 2022
@dmitryax
Add Tyler Helmuth as an approver
50589f1 
Tyler has been actively involved in this repo recently. The following PR were submitted or reviewed:
- #129
- #131
- #139
- #147
- #151
- #142
- #143
- #148

cc @open-telemetry/helm-approvers
@dmitryax dmitryax mentioned this pull request Mar 18, 2022
Merged
dmitryax added a commit that referenced this pull request Mar 20, 2022
@dmitryax
Add Tyler Helmuth as an approver (#152)
49ecad4 
Tyler has been actively involved in this repo recently. The following PR were submitted or reviewed:
- #129
- #131
- #139
- #147
- #151
- #142
- #143
- #148

cc @open-telemetry/helm-approvers
@TylerHelmuth TylerHelmuth mentioned this pull request Mar 20, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@dmitryax dmitryax dmitryax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mat-rumian @TylerHelmuth @dmitryax