-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collector chart 0.9.4 cannot be deployed with some helm versions #143
Conversation
|
Thanks @bender316, can you please sign the CLA? |
Great catch. @dmitryax think there is a test we could add to the workflow that would've caught this? |
@TylerHelmuth Yes, we have it already, it's failing |
😬 where? |
@TylerHelmuth Oh I was thinking you are talking about CLA :) Catching issues like the one fixed in this PR makes sense. Probably we can have a matrix of popular helm versions in the lint-test job. @bender316 which helm version do you use when it's failing? |
I like this idea. Maybe test against the latest helm version and a couple previous Latest Stable Versions. |
Sounds good |
Done. |
The helm chart with 0.9.4 set
additionalProperties
to false invalues.schema.json
.Depending on the helm version used the chart fails to be deployed with the following error message:
- (root): Additional property global is not allowed
There is also an issue already in the helm repository:
helm/helm#10392
Current established workaround is to add global to the allowed properties or set additionalProperties to true. I choose the first possibility