-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sidecar example in Operator README #183
Update sidecar example in Operator README #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make the example correct by making it be OTLP instead of jaeger.
otlp:
protocols:
grpc:
http:
...
service:
pipelines:
traces:
receivers: [otlp]
processors: []
exporters: [logging]
I suggest doing the same in the operator repo's README
@erichsueh3 please bump the operator chart version. |
@TylerHelmuth The example does not work with the otlp receiver, I think because the |
I should've read down further to see the image. Thanks for the clarification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why grpc
isn't working? It is the default protocol according to the receiver.
What do you mean by default protocol? A protocol must be specified in the |
You're right, shouldve said "a protocol". I would expect grpc as a protocol to work, unless the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming jaegertracing/vertx-create-span:operator-e2e-tests
can't send over GRPC and can send over thrift_compact
then this looks good to me. I would hold off on merging until the operator PR is approved, to ensure this example stays up-to-date with any feedback from that PR.
Yes, after testing it myself, it seems like it could only send over |
This PR updates the sidecar example in the Operator README, as it does not work. It changes the
jaegerreceiver
protocol tothrift_compact
instead ofgrpc
. This is also reflected in a PR on theopentelemetry-operator
repository, 837.