Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sidecar example in README #837

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

erichsueh3
Copy link
Contributor

@erichsueh3 erichsueh3 commented Apr 25, 2022

This PR updates the sidecar example in the README, as it does not work. It removes the unnecessary otlpreceiver and changes the jaegerreceiver protocol to thrift_compact instead of grpc. This is also reflected in a PR on the opentelemetry-helm-charts repository, 183.

@pavolloffay
Copy link
Member

I would rather have an example using the OTEL instrumentation and not Jaeger, but it's not in the scope of this PR.

@pavolloffay pavolloffay merged commit 6273de6 into open-telemetry:main Apr 26, 2022
@erichsueh3 erichsueh3 deleted the README_sidecar_update branch April 26, 2022 19:17
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants