Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add api usage snippets #498

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Add api usage snippets #498

merged 5 commits into from
Oct 2, 2024

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Sep 30, 2024 •
edited
Loading

Code snippets support opentelemetry.io PR: open-telemetry/opentelemetry.io#5276

@jack-berg jack-berg mentioned this pull request Sep 30, 2024
Open
@jack-berg jack-berg marked this pull request as ready for review September 30, 2024 17:42
@jack-berg jack-berg requested review from a team as code owners September 30, 2024 17:42
trask
trask reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of comments about comments (if you accept them, there are several duplicates throughout)

doc-snippets/api/src/main/java/otel/AsyncCounterUsage.java Outdated Show resolved Hide resolved
doc-snippets/api/src/main/java/otel/AsyncCounterUsage.java Outdated Show resolved Hide resolved
doc-snippets/api/src/main/java/otel/AsyncGaugeUsage.java Outdated Show resolved Hide resolved
doc-snippets/api/src/main/java/otel/AsyncGaugeUsage.java Outdated Show resolved Hide resolved
jaydeluca
jaydeluca approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@jaydeluca jaydeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewing this was fun, thanks for the tour of the api! I think these are really useful examples and the added commentary is great

doc-snippets/api/src/main/java/otel/SpanUsage.java Outdated Show resolved Hide resolved
trask
trask approved these changes Oct 2, 2024
View reviewed changes
doc-snippets/api/src/main/java/otel/LogRecordUsage.java Outdated Show resolved Hide resolved
doc-snippets/api/src/main/java/otel/SpanUsage.java Outdated Show resolved Hide resolved
@jack-berg jack-berg merged commit dd12ee9 into open-telemetry:main Oct 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@jaydeluca jaydeluca jaydeluca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jack-berg @trask @jaydeluca