-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor java instrumentation #5276
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jack-berg - please rebase and resolve conflicts before we proceed:
I've merged |
Yes rebase from a freshly updated upstream |
This is the kind of wonkiness that can happen. Please rebase from a freshly updated upstream |
769aae6
to
fe3100a
Compare
That did the trick. Thanks! |
@jack-berg can you check with @open-telemetry/java-approvers that at least one of them is also taking a look through the changes? |
Thanks for the review @jaydeluca 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, there are a few open discussions we should close and then wrap this up :-)
49ad914
to
31f6f96
Compare
We have one remaining open conversation here. Discussing here because that thread is buried and hard to find. I feel like the easiest path forward is to just remove the links from the translated versions of libraries to the now removed java sections, like I had originally done. Probably not a solution to the general case, but in this case, there are no translated versions of the instrumentation page being modified, and the link probably shouldn't have been there in the first place. WDYT? |
We need a quick solution to merge this PR, and we need a long term solution to ensure that we can run translations while updating the (English) documentation. For the quick solution, I'd like to lean on whatever @chalin suggests to do, to get this PR merged. |
31f6f96
to
1a458de
Compare
Related to #5211. Followup to #4966.
This PR breaks up and adds coherence to the topics currently discussed in Instrumentation:
The PR for the code snippet additions to
opentelemetry-java-examples
is available here: open-telemetry/opentelemetry-java-examples#498There is a lot of content in this PR, but like #4966, the principles are simple and scalable. I recommend reviewing by looking at the rendered website. Links to previews for main pages involved:
cc @open-telemetry/java-approvers, @open-telemetry/java-instrumentation-approvers