Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align operator version with the tooling around it #37

Closed
jpkrohling opened this issue Aug 19, 2020 · 1 comment · Fixed by #172
Closed

Align operator version with the tooling around it #37

jpkrohling opened this issue Aug 19, 2020 · 1 comment · Fixed by #172
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@jpkrohling
Copy link
Member

We currently get the operator's version based on git tags, which brings a v prefix to the version. Some of the tooling around the operator/kubebuilder expects numeric versions, so, we should adjust the Makefile to use the appropriate notations.

Example:

$ make bundle
...
...
FATA[0000] invalid command options: release/v0.2.0-2-gb203820 is not a valid semantic version: Invalid character(s) found in major number "release/v0"
@jpkrohling jpkrohling added bug Something isn't working good first issue Good for newcomers hacktoberfest labels Aug 19, 2020
@jpkrohling jpkrohling mentioned this issue Aug 19, 2020
Merged
3 tasks
@mneverov
Copy link
Contributor

hi, i'd like to work on this

mneverov added a commit to mneverov/opentelemetry-operator that referenced this issue Jan 24, 2021
@mneverov
Added project name to the PROJECT config file.
f1c69ab 
projectName field is needed for operator-sdk to deduct the metadata name for the
project. When the bundle command reads input files from the stdin and no --project
argument is provided, and projectName is absent the generated metadata name has
invalid pattern: '.v0.18.0'.
This commit adds the projectName field so metadata.name is correctly generated.

Fixes open-telemetry#37
@mneverov mneverov mentioned this issue Jan 24, 2021
Merged
mneverov added a commit to mneverov/opentelemetry-operator that referenced this issue Jan 25, 2021
@mneverov
Added project name to the PROJECT config file.
a428dcc 
projectName field is needed for operator-sdk to deduct the metadata name for the
project. When the bundle command reads input files from the stdin and no --project
argument is provided, and projectName is absent the generated metadata name has
invalid pattern: '.v0.18.0'.
This commit adds the projectName field so metadata.name is correctly generated.

Fixes open-telemetry#37
mneverov added a commit to mneverov/opentelemetry-operator that referenced this issue Jan 25, 2021
@mneverov
Added project name to the PROJECT config file.
a11c42b 
projectName field is needed for operator-sdk to deduct the metadata name for the
project. When the bundle command reads input files from the stdin and no --project
argument is provided, and projectName is absent the generated metadata name has
invalid pattern: '.v0.18.0'.
This commit adds the projectName field so metadata.name is correctly generated.

Fixes open-telemetry#37
@mergify mergify bot closed this as completed in #172 Jan 25, 2021
mergify bot pushed a commit that referenced this issue Jan 25, 2021
@mneverov
Added project name to the PROJECT config file (#172)
a1c6f8a 
Added project name to the PROJECT config file

projectName field is needed for operator-sdk to deduct the metadata name for the
project. When the bundle command reads input files from the stdin and no --project
argument is provided, and projectName is absent the generated metadata name has
invalid pattern: '.v0.18.0'.
This commit adds the projectName field so metadata.name is correctly generated.

Fixes #37
shree007 pushed a commit to shree007/opentelemetry-operator that referenced this issue Dec 12, 2021
@mneverov
Added project name to the PROJECT config file (open-telemetry#172)
467f0eb 
Added project name to the PROJECT config file

projectName field is needed for operator-sdk to deduct the metadata name for the
project. When the bundle command reads input files from the stdin and no --project
argument is provided, and projectName is absent the generated metadata name has
invalid pattern: '.v0.18.0'.
This commit adds the projectName field so metadata.name is correctly generated.

Fixes open-telemetry#37
dt-cloner bot pushed a commit to IshwarKanse/opentelemetry-operator that referenced this issue Apr 17, 2024
@openshift-merge-bot
Merge pull request open-telemetry#37 from IshwarKanse/rebase-bot-main
be6d2bf 
Merge https://github.com/open-telemetry/opentelemetry-operator:main (ad0f1f9) into main
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this issue May 1, 2024
@mneverov
Added project name to the PROJECT config file (open-telemetry#172)
4f4dbb6 
Added project name to the PROJECT config file

projectName field is needed for operator-sdk to deduct the metadata name for the
project. When the bundle command reads input files from the stdin and no --project
argument is provided, and projectName is absent the generated metadata name has
invalid pattern: '.v0.18.0'.
This commit adds the projectName field so metadata.name is correctly generated.

Fixes open-telemetry#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added project name to the PROJECT config file mneverov/opentelemetry-operator
2 participants
@jpkrohling @mneverov