Migrated to Operator SDK 0.19 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinearls, would you like to review the tests? |
|
@jpkrohling I'd like to but unfortunately probably won't have a chance until Monday |
objectiser
reviewed
Aug 13, 2020
Closed
|
|
jpkrohling
force-pushed
the
jpkrohling/issue23
branch
from
c49062b to
0ad549a
Compare
objectiser
approved these changes
Aug 18, 2020
jpkrohling
force-pushed
the
jpkrohling/issue23
branch
from
38ce5c9 to
4a88da9
Compare
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
jpkrohling/issue23
branch
from
4a88da9 to
b203820
Compare
|
Sorry, I force-pushed a squashed version of the PR when trying to figure out the CLA failure. I promise I didn't change anything other than the places where you commented :-) |
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
dt-cloner bot
pushed a commit
to IshwarKanse/opentelemetry-operator
that referenced
this pull request
Apr 3, 2024
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items to be completed in a follow-up PR:
Tests for the specific reconciliation tasks (config maps, deployments, ...)tracking issue: Tests for reconcilers #35Publishing of the container imagesPublish container images #36Change theAlign operator version with the tooling around it #37versionto not have avprefix, in line with what the kubebuilder tooling expects. We can add the prefix where we expect thevprefix to existCloses #23
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de