Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-Adding metrics level into the tests #975

Closed
wants to merge 2 commits into from
Closed

Re-Adding metrics level into the tests #975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55f6814
Re-Adding metrics level into the tests
yuriolisa Jul 13, 2022
1083416
Re-Adding metrics level into the tests
yuriolisa Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/e2e/instrumentation-java/00-install-collector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,6 @@ spec:
receivers: [otlp]
processors: []
exporters: [logging]
telemetry:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of this change? It changes OTELcol's config that is used in the test. How is this change being asserted? Is this even needed for the auto-instrumentation (I would say it's not)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put back that configuration because we have removed it on the following PR: #680.
I agree that we should explore the test assertion and remove them from the auto-instrumentation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, a short comment on why this is needed and where it's used would be helpful.

metrics:
level: detailed
3 changes: 3 additions & 0 deletions tests/e2e/instrumentation-nodejs-multicontainer/00-install-collector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,6 @@ spec:
receivers: [otlp]
processors: []
exporters: [logging]
telemetry:
metrics:
level: detailed
3 changes: 3 additions & 0 deletions tests/e2e/instrumentation-nodejs/00-install-collector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,6 @@ spec:
receivers: [otlp]
processors: []
exporters: [logging]
telemetry:
metrics:
level: detailed
3 changes: 3 additions & 0 deletions tests/e2e/instrumentation-python-multicontainer/00-install-collector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,6 @@ spec:
receivers: [otlp]
processors: []
exporters: [logging]
telemetry:
metrics:
level: detailed
3 changes: 3 additions & 0 deletions tests/e2e/instrumentation-python/00-install-collector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,6 @@ spec:
receivers: [otlp]
processors: []
exporters: [logging]
telemetry:
metrics:
level: detailed
3 changes: 3 additions & 0 deletions tests/e2e/smoke-pod-annotations/00-install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,6 @@ spec:
receivers: [jaeger]
processors: []
exporters: [logging]
telemetry:
metrics:
level: detailed
3 changes: 3 additions & 0 deletions tests/e2e/smoke-restarting-deployment/00-install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,6 @@ spec:
receivers: [jaeger]
processors: []
exporters: [logging]
telemetry:
metrics:
level: detailed
3 changes: 3 additions & 0 deletions tests/e2e/smoke-restarting-deployment/01-install-second-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,7 @@ spec:
receivers: [jaeger, otlp]
processors: []
exporters: [logging]
telemetry:
metrics:
level: detailed

5 changes: 4 additions & 1 deletion tests/e2e/smoke-simplest/00-install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,7 @@ spec:
traces:
receivers: [jaeger,otlp]
processors: []
exporters: [logging]
exporters: [logging]
telemetry:
metrics:
level: detailed