Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/metrics instrumentation urllib3 #1198

Merged
merged 18 commits into from
Aug 9, 2022
Merged

Feature/metrics instrumentation urllib3 #1198

merged 18 commits into from
Aug 9, 2022

Conversation

shalevr
Copy link
Member

@shalevr shalevr commented Jul 19, 2022 •
edited by srikanthccv
Loading

Description

Add metrics instrumentation for urllib3

Fixes #1144

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e test-instrumentation-urllib3

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added

@shalevr shalevr requested a review from a team July 19, 2022 11:33
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 19, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@shalevr shalevr force-pushed the feature/Metrics-instrumentation-urllib3 branch from f13b4c7 to 1484ef0 Compare July 26, 2022 13:42
@shalevr shalevr force-pushed the feature/Metrics-instrumentation-urllib3 branch from 3cad099 to f4261ba Compare July 26, 2022 14:10
@shalevr shalevr force-pushed the feature/Metrics-instrumentation-urllib3 branch from 0f66541 to 56fb196 Compare July 27, 2022 11:15
@shalevr shalevr force-pushed the feature/Metrics-instrumentation-urllib3 branch from 56fb196 to 471dadf Compare July 27, 2022 14:51
srikanthccv
srikanthccv suggested changes Jul 28, 2022
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe uninstrument should stop producing all telemetry including metrics. I am going to bring this up in today's SIG. Blocking the accidental merge meanwhile.

@lzchen
Copy link
Contributor

lzchen commented Aug 2, 2022

Please update the metrics support for this instrumentation here

@srikanthccv
Copy link
Member

Add _supports_metrics=True in the package.py file like this and run tox -e generate and it should be updated automatically.

@srikanthccv
Copy link
Member

@shalevr We will need tests to make sure uninstrument doesn't generate any measurements.

@shalevr shalevr force-pushed the feature/Metrics-instrumentation-urllib3 branch from fa9a8a5 to fcb2d42 Compare August 4, 2022 08:22
@shalevr shalevr force-pushed the feature/Metrics-instrumentation-urllib3 branch from 0bbc7a0 to 9db1dba Compare August 8, 2022 08:56
shalevr added 2 commits August 8, 2022 22:46
@shalevr
Fixed after CR
cfbb620
@shalevr
Merge branch 'feature/Metrics-instrumentation-urllib3' of https://git…
3a11327 
…hub.com/shalevr/opentelemetry-python-contrib into feature/Metrics-instrumentation-urllib3

* 'feature/Metrics-instrumentation-urllib3' of https://github.com/shalevr/opentelemetry-python-contrib:
  Metric instrumentation asgi (open-telemetry#1197)
  Metrics instrumentation flask (open-telemetry#1186)
  Adding sqlalchemy native tags in sqlalchemy commenter (open-telemetry#1206)
@srikanthccv srikanthccv enabled auto-merge (squash) August 9, 2022 05:38
@srikanthccv srikanthccv merged commit be96403 into open-telemetry:main Aug 9, 2022
shalevr added a commit to shalevr/opentelemetry-python-contrib that referenced this pull request Aug 30, 2022
@shalevr
Merge branch 'main' into metrics-instrumentation-tornado
c336916 
* main:
  Codespell ci (open-telemetry#1237)
  aiohttp-client: Fix producing additional spans with each newly created ClientSession (open-telemetry#1246)
  Remove support for 3.6 (open-telemetry#853)
  Added the Licence and Manifest file
  Restore metrics in django (open-telemetry#1208)
  fix typo in example codes (open-telemetry#1240)
  boto3sqs: Make propagation compatible with other instrumentations and add 'messaging.url' span attribute (open-telemetry#1234)
  Release 1.12.0-0.33b0 (open-telemetry#1223)
  Fix Flask instrumentation doc link (open-telemetry#1216)
  Feature/metrics instrumentation urllib3 (open-telemetry#1198)
  Metric instrumentation asgi (open-telemetry#1197)
  Metrics instrumentation flask (open-telemetry#1186)
  Adding sqlalchemy native tags in sqlalchemy commenter (open-telemetry#1206)
  ci: fix docs workflow failure (open-telemetry#1211)
  Add psycopg2 native tags to sqlcommenter (open-telemetry#1203)
  SQLCommenter semicolon bug fix (open-telemetry#1200)
  Sync with sdk setup from setUpClass to setUp (open-telemetry#1193)

# Conflicts:
#	CHANGELOG.md
#	instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py
#	instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/client.py
@shalevr shalevr mentioned this pull request Oct 13, 2022
Closed
6 tasks
@shalevr shalevr mentioned this pull request Dec 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@lzchen lzchen lzchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics instrumentation urllib3
4 participants
@shalevr @lzchen @srikanthccv @ocelotl