Fix expected URL in aiohttp instrumentation test #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalevr
approved these changes
Apr 24, 2023
This reverts commit 3ed4663.
The underlying cause of the issue here is the update of the yarl package from 1.8.2 to 1.9.1. yarl is used as a dependency in the opentelemetry-instrumentation-aiohttp package but it is not there where the issue happens, but in aiohttp who also has yarl as a dependency. This is why the fix does not touch any relevant part of any opentelemetry-* code, since it is the return value of aiohttp code who now has a different value for the URL. Fixes open-telemetry#1770
5 tasks
|
Can you add a description of why the test broke and how this fixes it? |
lzchen
approved these changes
Apr 25, 2023
There is already a description in the latest commit, adding it in the PR as well ✌️ |
musicinmybrain
added a commit
to musicinmybrain/opentelemetry-python-contrib
that referenced
this pull request
May 23, 2023
The minimum version ensures the expected URL string in the tests is consistent; see open-telemetry#1772. The yarl dependency is needed both for the package and for the tests.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1770
The underlying cause of the issue here is the update of the yarl package
from 1.8.2 to 1.9.1. yarl is used as a dependency in the
opentelemetry-instrumentation-aiohttp package but it is not there where
the issue happens, but in aiohttp who also has yarl as a dependency.
This is why the fix does not touch any relevant part of any
opentelemetry-* code, since it is the return value of aiohttp code who
now has a different value for the URL.