-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grpc): aio grpc client interceptor incorrect metadata handling #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
approved these changes
Mar 22, 2024
Thanks for the PR @legau
Do you know if this change is backward compatible to older gRPC versions before v1.60.0? |
aabmass
approved these changes
Apr 4, 2024
...ion/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_aio_client.py
Show resolved
Hide resolved
This transforms the tuple of <1.60 into a Metadata object so yes it is backwards compatible |
aabmass
approved these changes
Apr 11, 2024
I added the changelog entry |
xrmx
approved these changes
Apr 12, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug when using grpcio>=1.60.0 and the gRPC telemetry. Introduced by grpc/grpc#34347 a tuple metadata is always converted to a
Metadata
object which follows the Python grpc docs and typing. In the current opentelemetry implementation there is a conversion to anOrderedDict
which causes :This PR makes use of the
Metadata
object directly and propagates it as such.This could cause regressions for some following interceptors handling metadata as tuples (same way this regression happened), I'm not sure if this would qualify as a breaking change though.
Type of change
How Has This Been Tested?
Added metadata in grpc tests
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.