Release AWS Python SDK Extension as 1.0 #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
force-pushed
the
release-aws-sdk-extension-1.0
branch
from
4ad84af to
9316992
Compare
NathanielRN
force-pushed
the
release-aws-sdk-extension-1.0
branch
from
9316992 to
a10be89
Compare
owais
approved these changes
Sep 8, 2021
ocelotl
approved these changes
Sep 9, 2021
lzchen
approved these changes
Sep 9, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With #596 and #598 merged we completed the major tasks we wanted to release packages from Contrib as 1.0 Instrumentation API is not stable so they cannot be released as 1.0, but packages that the maintainers feel comfortable to release can be released as 1.0.
With that said, I became the CODEOWNER for the
sdk-extension/opentelemetry-sdk-extension-awspackage in #655 , and after bringing it up at the SIG meeting got the go-ahead to release this package as 1.0!The
sdk-extension/opentelemetry-sdk-extension-awspackage only depends onopentelemetry-sdk, which is 1.0 stable as well so it should give us confidence the APIs needed for thissdk-extensionpackage are also stable.See:
opentelemetry-python-contrib/sdk-extension/opentelemetry-sdk-extension-aws/setup.cfg
Lines 40 to 41 in 704f1d9
Once we merge this, we can try the changes from #598 to release from a tag. (e.g.
opentelemetry-sdk-extension-aws==1.0.0)Type of change
Individual Contrib package release.
How Has This Been Tested?
N/A
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
- [ ] Unit tests have been added- [ ] Documentation has been updated