Patch update SDK Extension AWS to version 1.0.1 #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Next intended should be 1.1.0 and in trunk version should be dev so this should be 1.1.0dev0 |
lzchen
reviewed
Sep 13, 2021
| @@ -23,7 +23,6 @@ url = https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/s | |||
| platforms = any | |||
| license = Apache-2.0 | |||
| classifiers = | |||
| Development Status :: 4 - Beta | |||
There was a problem hiding this comment.
Should add the stable classifier.
There was a problem hiding this comment.
Thanks for that!
NathanielRN
force-pushed
the
move-sdk-extension-aws-1.0.1b0
branch
from
491cedf to
c35d031
Compare
NathanielRN
changed the title
NathanielRN
force-pushed
the
move-sdk-extension-aws-1.0.1b0
branch
from
c35d031 to
5ecffb9
Compare
|
@owais Thanks for the tip! I wasn't sure what to set for it so thanks for calling that out 🙂 I actually decided to make this a patch version I'll follow up with a new PR afterwards to set it to @open-telemetry/opentelemetry-python-contrib-maintainers Once this passes CI and gets merged, could you please push the |
NathanielRN
force-pushed
the
move-sdk-extension-aws-1.0.1b0
branch
from
5ecffb9 to
43c5c97
Compare
lzchen
approved these changes
Sep 14, 2021
codeboten
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After releasing the opentelemetry-sdk-extension-aws package as 1.0.0, we should update the development version to be a beta version like we normally do for packages.
This PR also removes the "Beta" classifier for the package.
Follow up to #667
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
N/A
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
- [ ] Changelogs have been updated- [ ] Unit tests have been added