Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent use of version files #4097

Closed
ocelotl opened this issue Jul 31, 2024 · 3 comments · Fixed by #4099
Closed

Inconsistent use of version files #4097

ocelotl opened this issue Jul 31, 2024 · 3 comments · Fixed by #4099
Assignees
@ocelotl

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jul 31, 2024 •
edited
Loading

Some packages use version/__init__.py, some use version.py. Fix that.
@ocelotl ocelotl added the bug Something isn't working label Jul 31, 2024
@ocelotl ocelotl self-assigned this Jul 31, 2024
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 31, 2024
@ocelotl
Rename version.py files to version/__init__.py
a09996a 
Fixes open-telemetry#4097
@ocelotl ocelotl mentioned this issue Jul 31, 2024
Merged
@ocelotl ocelotl removed the bug Something isn't working label Jul 31, 2024
@emdneto
Copy link
Member

emdneto commented Aug 6, 2024

@ocelotl is this duplicate of #4077 ?

@ocelotl ocelotl mentioned this issue Aug 8, 2024
Closed
@ocelotl
Copy link
Contributor Author

ocelotl commented Aug 8, 2024

Jul 31, 2024
@emdneto

Right, keeping this one as it already has a PR.

@ocelotl
Copy link
Contributor Author

ocelotl commented Aug 8, 2024

The change from version.py to version/__init__.py came from the fix for #3385.

ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 6, 2024
@ocelotl
Rename version.py files to version/__init__.py
d1f4166 
Fixes open-telemetry#4097
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 11, 2024
@ocelotl
Rename version.py files to version/__init__.py
3c6d747 
Fixes open-telemetry#4097
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 11, 2024
@ocelotl
Rename version.py files to version/__init__.py
eb25474 
Fixes open-telemetry#4097
@ocelotl ocelotl mentioned this issue Sep 16, 2024
Closed
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 20, 2024
@ocelotl
Rename version.py files to version/__init__.py
002d6d0 
Fixes open-telemetry#4097
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 20, 2024
@ocelotl
Rename version.py files to version/__init__.py
2ee8908 
Fixes open-telemetry#4097
ocelotl added a commit that referenced this issue Sep 25, 2024
@ocelotl
Rename version.py files to version/__init__.py (#4099)
cafd7f2 
* Rename version.py files to version/__init__.py

Fixes #4097

* Use a better variable name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ocelotl @emdneto