Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show how get_metrics_data can return None #4190

Closed
wants to merge 1 commit into from
Closed

Show how get_metrics_data can return None #4190

wants to merge 1 commit into from

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Sep 16, 2024 •
edited
Loading

Fixes #4097

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 16, 2024
@ocelotl ocelotl changed the title Rename version.py files to version/__init__.py Show how get_metrics_data can return None Sep 16, 2024
@ocelotl ocelotl mentioned this pull request Sep 16, 2024
Closed
@Ali-Alnosairi
Copy link
Contributor

Hi @ocelotl ,
I think this one is related to 4186
please take a look to review it !

@emdneto
Copy link
Member

emdneto commented Oct 11, 2024

Closing as fixed in #4186

@emdneto emdneto closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent use of version files
3 participants
@ocelotl @Ali-Alnosairi @emdneto