Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sampling result names #1128

Merged
merged 4 commits into from
Sep 18, 2020
Merged

Update sampling result names #1128

merged 4 commits into from
Sep 18, 2020

Conversation

ffe4
Copy link
Contributor

@ffe4 ffe4 commented Sep 17, 2020

Description

Update to #1115 since there was another renaming in the spec open-telemetry/opentelemetry-specification#956

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated

@ffe4 ffe4 requested a review from a team September 17, 2020 13:00
@ffe4 ffe4 changed the title Sampling result names Update sampling result names Sep 17, 2020
@ffe4 ffe4 mentioned this pull request Sep 17, 2020
Merged
1 task
@codeboten codeboten added the release:required-for-ga To be resolved before GA release label Sep 17, 2020
@aabmass aabmass self-assigned this Sep 17, 2020
codeboten
codeboten approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzchen lzchen merged commit a59e268 into open-telemetry:master Sep 18, 2020
alertedsnake pushed a commit to alertedsnake/opentelemetry-python that referenced this pull request Sep 25, 2020
@ffe4
Update sampling result names (open-telemetry#1128)
326f45a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@aabmass aabmass

Labels
release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ffe4 @codeboten @lzchen @aabmass