Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update names of decisions in SamplingResult #1115

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Update names of decisions in SamplingResult #1115

merged 2 commits into from
Sep 16, 2020
+27 −25

Conversation

ffe4
Copy link
Contributor

@ffe4 ffe4 commented Sep 15, 2020

Description

The names for the sampling result names need updating after open-telemetry/opentelemetry-specification#938

spec: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#sampler

  • Changelogs have been updated

@ffe4 ffe4 requested a review from a team September 15, 2020 19:57
codeboten
codeboten approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@codeboten codeboten merged commit 1abdc02 into open-telemetry:master Sep 16, 2020
@ffe4 ffe4 deleted the sampling-result-names branch September 17, 2020 07:14
@arminru
Copy link
Member

arminru commented Sep 17, 2020

@open-telemetry/python-maintainers
Thanks for the quick update! There was a follow-up renaming it once again, however:
https://github.com/open-telemetry/opentelemetry-specification/pull/956/files

@ffe4 ffe4 mentioned this pull request Sep 17, 2020
Merged
2 tasks
@ffe4
Copy link
Contributor Author

ffe4 commented Sep 17, 2020

Thanks for letting us know @arminru. I submitted a follow-up PR #1128

alertedsnake pushed a commit to alertedsnake/opentelemetry-python that referenced this pull request Sep 25, 2020
@ffe4
Update names of decisions in SamplingResult (open-telemetry#1115)
6ebc220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@codeboten codeboten codeboten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ffe4 @arminru @codeboten @lzchen