Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of pkg_resources #3047

Merged
merged 29 commits into from
Feb 1, 2023
Merged

Remove usage of pkg_resources #3047

merged 29 commits into from
Feb 1, 2023

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Nov 21, 2022

Fixes #2927

@ocelotl ocelotl self-assigned this Nov 21, 2022
@ocelotl ocelotl changed the title Issue 2927 Remove usage of pkg_resources Nov 23, 2022
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 23, 2022
@ocelotl ocelotl added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Nov 23, 2022
@ocelotl ocelotl marked this pull request as ready for review November 28, 2022 19:46
@ocelotl ocelotl requested a review from a team November 28, 2022 19:46
@ocelotl ocelotl mentioned this pull request Nov 28, 2022
Open
@ocelotl ocelotl force-pushed the issue_2927 branch 2 times, most recently from 825bc57 to 774a67e Compare December 1, 2022 12:55
@ocelotl ocelotl force-pushed the issue_2927 branch 2 times, most recently from 01243dc to 4bb970b Compare December 6, 2022 15:48
@ocelotl ocelotl marked this pull request as draft December 6, 2022 15:52
@ocelotl ocelotl marked this pull request as ready for review December 6, 2022 21:50
@ocelotl ocelotl requested review from lzchen and mariojonke and removed request for mariojonke December 6, 2022 21:57
@ocelotl ocelotl force-pushed the issue_2927 branch 2 times, most recently from c6435b1 to 20bbd2c Compare December 14, 2022 21:36
@ocelotl ocelotl force-pushed the issue_2927 branch 2 times, most recently from c5a1c55 to 997f7a4 Compare February 1, 2023 22:31
@ocelotl ocelotl merged commit 2e14fe1 into open-telemetry:main Feb 1, 2023
@ocelotl ocelotl deleted the issue_2927 branch February 1, 2023 23:48
@aabmass aabmass mentioned this pull request Feb 10, 2023
Closed
7 tasks
@jenshnielsen jenshnielsen mentioned this pull request Feb 15, 2023
Closed
@ocelotl ocelotl mentioned this pull request Feb 23, 2023
Closed
jenshnielsen added a commit to jenshnielsen/opentelemetry-python that referenced this pull request Jul 6, 2023
@jenshnielsen
Drop setuptools as runtime dependency
5cb8b48 
This was originally added in open-telemetry#2334 but the runtime dependency
on pkg_resources was since dropped in open-telemetry#3047 so the dependency
can be dropped
@jenshnielsen jenshnielsen mentioned this pull request Jul 6, 2023
Merged
7 tasks
jenshnielsen added a commit to jenshnielsen/opentelemetry-python that referenced this pull request Jul 6, 2023
@jenshnielsen
Drop setuptools as runtime dependency
eca1319 
This was originally added in open-telemetry#2334 but the runtime dependency
on pkg_resources was since dropped in open-telemetry#3047 so the dependency
can be dropped
@jenshnielsen jenshnielsen mentioned this pull request Sep 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

@mariojonke mariojonke mariojonke approved these changes

Assignees

@ocelotl ocelotl

Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace usage of pkg_resources (setuptools) with importlib(._)resources?
4 participants
@ocelotl @lzchen @srikanthccv @mariojonke