Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editorial] Ensure all ToCs are generated using markdown-toc #2146

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 22, 2021

Enures that all ToCs are uniformly wrapped in:

  • <!-- toc --> and <!-- tocstop --> so that they get regenerated by markdown-toc and checked during CI
  • <details><summary>Table of Contents</summary> ... </details>

/cc @austinlparker

@chalin chalin requested review from a team November 22, 2021 16:33
@arminru arminru added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Nov 22, 2021
Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@arminru

This comment has been minimized.

@carlosalberto
Copy link
Contributor

Oops, we should have merged this earlier as it was an editorial change, sorry for that @chalin -- would you mind rebasing and fixing the conflicts?

@chalin chalin force-pushed the chalin-uniform-toc-2021-11-22 branch from 4f69319 to 237bd66 Compare November 24, 2021 14:48
@chalin
Copy link
Contributor Author

chalin commented Nov 24, 2021

@carlosalberto - rebased, pushed, and all checks are green.

@carlosalberto carlosalberto merged commit e2c2472 into open-telemetry:main Nov 24, 2021
@chalin chalin deleted the chalin-uniform-toc-2021-11-22 branch November 24, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants