Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to really clarify that you need flask and wekzeug < 3 #4034

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Conversation

cartermp
Copy link
Contributor

The evergreen problem that causes 50+ reply threads in slack persists. Herein I try to make it a little more clear what you need to do, until such a time that this resolves upstream.

@cartermp cartermp requested review from a team February 21, 2024 17:09
@cartermp
Copy link
Contributor Author

/fix:all

@cartermp
Copy link
Contributor Author

I swear to fuckin god github actions

@rivToadd
Copy link

bless

@cartermp
Copy link
Contributor Author

Gonna merge this so we have all our bases covered on this limitation for now. Nothing about the guidance is changed, it's just added in more places.

@cartermp cartermp merged commit 6e8b143 into main Feb 21, 2024
16 checks passed
@cartermp cartermp deleted the cartermp/fuck branch February 21, 2024 21:46
@aabmass
Copy link
Member

aabmass commented Feb 21, 2024

I'm a little confused, this should have been fixed in open-telemetry/opentelemetry-python-contrib#2013

@cartermp
Copy link
Contributor Author

Hrm. Is that released? When I follow the Getting Started guide on a fresh flask app (and I don't explicitly pin flask and werkzeug to <3) then I won't see traces, only logs.

@aabmass
Copy link
Member

aabmass commented Feb 22, 2024

I think it should have been released. I'll look into it

@aabmass
Copy link
Member

aabmass commented Feb 22, 2024

@cartermp, I was wrong it hasn't been released yet. The python maintainers are making a release this week. We can hopefully revert this PR after that's out.

@cartermp
Copy link
Contributor Author

Gotcha! Okay, I'll stand by to update stuff on this end when it's ready. Great news to hear.

@aabmass
Copy link
Member

aabmass commented Feb 23, 2024

Hey @cartermp , the latest release just went out and I tested the getting started with flask 3 and it works. I think we can revert this PR and change the instructions:

-pip install 'flask<3' 'werkzeug<3'
pip install flask

@cartermp
Copy link
Contributor Author

Awesome @aabmass -- I'll submit a PR and tag you on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants