-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to really clarify that you need flask and wekzeug < 3 #4034
Conversation
/fix:all |
I swear to fuckin god github actions |
bless |
Gonna merge this so we have all our bases covered on this limitation for now. Nothing about the guidance is changed, it's just added in more places. |
I'm a little confused, this should have been fixed in open-telemetry/opentelemetry-python-contrib#2013 |
Hrm. Is that released? When I follow the Getting Started guide on a fresh flask app (and I don't explicitly pin flask and werkzeug to <3) then I won't see traces, only logs. |
I think it should have been released. I'll look into it |
@cartermp, I was wrong it hasn't been released yet. The python maintainers are making a release this week. We can hopefully revert this PR after that's out. |
Gotcha! Okay, I'll stand by to update stuff on this end when it's ready. Great news to hear. |
Hey @cartermp , the latest release just went out and I tested the getting started with flask 3 and it works. I think we can revert this PR and change the instructions: -pip install 'flask<3' 'werkzeug<3'
pip install flask |
Awesome @aabmass -- I'll submit a PR and tag you on it |
The evergreen problem that causes 50+ reply threads in slack persists. Herein I try to make it a little more clear what you need to do, until such a time that this resolves upstream.