Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirements for flask and werkzeug in Pythn docs #4047

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

cartermp
Copy link
Contributor

Flask 3 is now supported in python instrumentations, meaning we can remove the specific instructions for installation + various warnings about that.

Ref: #4034 (comment)

cc @aabmass

@cartermp cartermp requested review from a team February 24, 2024 21:47
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new instrumentation release isn't yet the default in the operator, so if we want to drop the notice in the operator docs, we should wait for its next release.

@TylerHelmuth
Copy link
Member

Operator python dep bump here: open-telemetry/opentelemetry-operator#2677

@swiatekm
Copy link
Contributor

I'm the release manager for operator 0.95.0, so I'll just approve this PR once it's out, if that's ok with everyone.

@cartermp
Copy link
Contributor Author

@swiatekm-sumo when is the new operator release planned? If it's soon then we can just wait until that's done, but if not then I'll change the Operator docs

@swiatekm
Copy link
Contributor

@cartermp should be out by the end of this week. If you'd prefer to drop the operator change from this PR, I can submit it by myself once the operator release is out.

@cartermp
Copy link
Contributor Author

Sounds good @swiatekm-sumo. I've updated everything here, good to merge?

@swiatekm swiatekm self-requested a review February 27, 2024 10:10
@svrnm svrnm merged commit fc6d4d0 into main Feb 27, 2024
16 checks passed
@svrnm svrnm deleted the cartermp/python-flask3 branch February 27, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants