add pvm instructions 5.10, 5.11, 5.12 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiweiii
commented
Aug 27, 2024
qiweiii
commented
Aug 27, 2024
| @@ -70,7 +70,7 @@ extension Ref where T == ProtocolConfig { | |||
| maxEncodedWorkReportSize: 96 * 1 << 10, | |||
| erasureCodedSegmentSize: 6, | |||
| ticketSubmissionEndSlot: 500, | |||
| pvmDynamicAddressAlignmentFactor: 4, | |||
| pvmDynamicAddressAlignmentFactor: 2, | |||
There was a problem hiding this comment.
need to use these in PolkaVM package, should I move this file to Utils or just move these pvm consts to PolkaVM
There was a problem hiding this comment.
Try to see if we can use generic.
protocol PvmConfig {
var pvmDynamicAddressAlignmentFactor: Int { get }
}and
extension ProtocolConfig: PvmConfig {}so that when testing PVM, we only need to create a PvmConfig, without get the whole ProtocolConfig in.
xlc
reviewed
Aug 28, 2024
qiweiii
changed the title
xlc
reviewed
Aug 28, 2024
Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
xlc
approved these changes
Aug 28, 2024
|
Only 68 failing pvm tests 🔥 |
MacOMNI
added a commit
that referenced
this pull request
Aug 29, 2024
MacOMNI
added a commit
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.