-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pvm instructions 5.10, 5.11, 5.12 #84
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
93101d4
fix name
qiweiii 9463ee0
add some instructions
qiweiii 7106561
add A.5.12 instructions
qiweiii 5302a2c
Merge branch 'master' into pvm/instructions-5.10
qiweiii a9cdfac
add to table
qiweiii 016caa0
fix
qiweiii 2eafe1b
add Pvm Config protocol
qiweiii d6acf83
Update PolkaVM/Sources/PolkaVM/Instructions.swift
qiweiii c072fd6
fix
qiweiii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
public protocol PvmConfig { | ||
// ZA = 2: The pvm dynamic address alignment factor. | ||
var pvmDynamicAddressAlignmentFactor: Int { get } | ||
|
||
// ZI = 2^24: The standard pvm program initialization input data size. | ||
var pvmProgramInitInputDataSize: Int { get } | ||
|
||
// ZP = 2^14: The standard pvm program initialization page size. | ||
var pvmProgramInitPageSize: Int { get } | ||
|
||
// ZQ = 2^16: The standard pvm program initialization segment size. | ||
var pvmProgramInitSegmentSize: Int { get } | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to use these in PolkaVM package, should I move this file to Utils or just move these pvm consts to PolkaVM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to see if we can use generic.
and
so that when testing PVM, we only need to create a PvmConfig, without get the whole ProtocolConfig in.