-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix xml namespace #344
base: master
Are you sure you want to change the base?
Fix xml namespace #344
Conversation
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
============================================
+ Coverage 70.28% 70.38% +0.10%
- Complexity 6314 6347 +33
============================================
Files 628 629 +1
Lines 21266 21350 +84
Branches 3411 3425 +14
============================================
+ Hits 14946 15028 +82
+ Misses 4713 4708 -5
- Partials 1607 1614 +7
Continue to review full report at Codecov.
|
Needs some extra work for the classes in #346 - not doing it there because it will cause nasty conflicts |
@javax.xml.bind.annotation.XmlSchema(namespace = "http://schemas.openehr.org/v1", /*xmlns = {@XmlNs(prefix = "", namespaceURI = "http://schemas.openehr.org/v1") | ||
|
||
}*/ elementFormDefault = XmlNsForm.QUALIFIED, attributeFormDefault = javax.xml.bind.annotation.XmlNsForm.UNQUALIFIED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some commented out things here, are they still needed?
Fixes #343 . Adds the http://schemas.openehr.org/v1 namespace to the JAXB-bindings.
note that this is a breaking change:
[name/value = '...']
will have to be changed to `[openehr:name/openehr:value = '...']. The regular path lookup remains unchanged.The alternative:
might be better than this actually...