Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm visibility #346

Merged
merged 15 commits into from
Sep 3, 2021
Merged

Rm visibility #346

merged 15 commits into from
Sep 3, 2021

Conversation

pieterbos
Copy link
Collaborator

@pieterbos pieterbos commented Aug 23, 2021

RM Overlay + visibility + alias support.

Done:

  • Model implementation
  • JAXB + Jackson binding
  • ADL parsing and serialization
  • added ad-codes as allows archetype nodes, added it to archetype.getAllusedCodes()
  • Flattener and OPT-creator
  • Test that parses, validates and flattens and creates and OPT
  • test that serializes and parses JSON (odin works, so json should be the same)
  • test that serializes and parses XML
  • test that serializes ADL
  • test that validates that ad-code is missing in the terminology
  • test and validation of an invalid path in archetype+RM
  • validate partial archetype path + reference model path suffix (also for annotations and more places?)
  • cleanup code for AOMPAthQuery.findPartial
  • Add test for AOMPathQuery.findPartial,
  • use the new path finding in AnnotationsValidation as well

TODO:
once we have standardized error codes, add those.

@pieterbos pieterbos mentioned this pull request Aug 24, 2021
@pieterbos pieterbos requested a review from J3173 August 25, 2021 10:51
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #346 (38656bc) into master (e82cfbb) will increase coverage by 0.11%.
The diff coverage is 76.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #346      +/-   ##
============================================
+ Coverage     70.28%   70.39%   +0.11%     
- Complexity     6314     6388      +74     
============================================
  Files           628      636       +8     
  Lines         21266    21475     +209     
  Branches       3411     3445      +34     
============================================
+ Hits          14946    15117     +171     
- Misses         4713     4738      +25     
- Partials       1607     1620      +13     
Impacted Files Coverage Δ
...ie/adlparser/treewalkers/CComplexObjectParser.java 84.93% <ø> (ø)
...rchie/adlparser/treewalkers/TerminologyParser.java 100.00% <ø> (ø)
...java/com/nedap/archie/aom/rmoverlay/RmOverlay.java 42.85% <42.85%> (ø)
...main/java/com/nedap/archie/query/PartialMatch.java 47.05% <47.05%> (ø)
...dap/archie/xml/types/XmlRmAttributeVisibility.java 62.50% <62.50%> (ø)
.../java/com/nedap/archie/xml/types/XmlRmOverlay.java 62.50% <62.50%> (ø)
...ap/archie/aom/rmoverlay/RmAttributeVisibility.java 66.66% <66.66%> (ø)
...nedap/archie/xml/adapters/RMOverlayXmlAdapter.java 72.72% <72.72%> (ø)
...main/java/com/nedap/archie/aom/utils/AOMUtils.java 73.77% <77.77%> (+0.43%) ⬆️
.../archie/serializer/adl/ADLArchetypeSerializer.java 80.28% <77.77%> (-0.37%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82cfbb...38656bc. Read the comment docs.

@pieterbos
Copy link
Collaborator Author

In the meantime, the ad-code for alias that was already in the standard got replaced by at-codes again. Beter, in my opinion. I will change that with processing review comments and before requesting re-review.

@pieterbos pieterbos requested a review from J3173 September 3, 2021 10:23
@pieterbos
Copy link
Collaborator Author

comments processed, ad-code replaced with at-code again.

@pieterbos pieterbos merged commit c9510c8 into master Sep 3, 2021
@pieterbos pieterbos deleted the rm_visibility branch September 3, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants